Opened 6 years ago

Closed 6 years ago

#751 closed defect (fixed)

What to do with weapon definitions in /weapons?

Reported by: beherith Owned by:
Priority: minor Milestone: BAR Beta release
Component: BAR Version:
Keywords: Cc:

Description (last modified by beherith)

Are the stuff there used at all? If a weapon has the same name in /weapons as the one defined in a unitdef which one gets used? I do agree that shared stuff like death explosions should be in /weapons, but I see some stuff there that really shouldnt be there, e.g.:

crblmssl.lua

nuclear_missile.lua

bantha_nuke.lua,

corgripn_bomb.lua,

rlrpc_death.lua

twilight.lua

Change History (6)

comment:1 by beherith, 6 years ago

Description: modified (diff)

comment:2 by Bluestone, 6 years ago

Often those ones are used both as explosions associated to weapons and as death/selfd explosions. There isn't any better way than grep to find out where its getting used afaik. If a single explosion is used between multiple weapons I think thats the only place it can go.

I suggest we leave units/weapons with the structure they already have; sorting those out should be one of the last things we do because it would make merges a nightmare.

Last edited 6 years ago by Bluestone (previous) (diff)

comment:3 by beherith, 6 years ago

note to self: the reason I asked this is that the 6 above mentioned weapon defs refer to projectile models (model = "..", tag), and these models no longer exist in BAR. probably easier to just swap out the models in these weapons.

comment:4 by Bluestone, 6 years ago

yes updating the models refered to is good (although i don't know if that tag actually does anything; i think its the tags in the unitdef that matter).

comment:5 by Bluestone, 6 years ago

[f=0000000] [weapondefs.lua] Error: removed rlrpc_death weaponDef, missing model [f=0000000] [weapondefs.lua] Error: removed bantha_nuke weaponDef, missing model [f=0000000] [weapondefs.lua] Error: removed nuclear_missile weaponDef, missing model

comment:6 by beherith, 6 years ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.