the map goes black when i order to build a wind turbine

[Bluestone]

for about 1 sec just after i give the build order

[Bluestone]

map was porky islands, which has nothing special about it afaik

[Bluestone]

can't find any other units that cause it

[Bluestone]

deferred rendering widget is responsible!

[Bluestone]

[11:24:26] <[teh]Beherith[PiRO]> could you try reverting 5126?

[beherith]

Attempted fix in [5134]

[Bluestone]

It still happens.

[Bluestone]

I've now had it happen with other units too - not sure quite what the trigger is.

[beherith]

It is definitely caused by the unit drawing part of inf_commands_fx. Ive spent quite a bit of time trying to debug it, short of whipping out geDebugger.

I cant find the root of the issue, even though nothing is actually drawn by the useshader portion of it. (nothing actually shows up, something may still be going on)

For now I would recommend just axing this part of the widget :(

Its wierd that corwin reproducibly triggers it, yet not many other units do so...

[Bluestone]

It must be something caused by interaction between the commands fx shader and the deferred rendering shader - for me disabling either of the two fixes the problem.

[Bluestone]

[09:53:20] <[Fx]Bluestone> i think if you can't see what's wrong, its entirely legitimate to ask kloot for help, since its his removal that means it has to be now done with a shader + seems clear that no one else knows how to do it either [09:53:52] <[Fx]Bluestone> it might well be another partly engine bug too

[beherith]

I fucking give up. Only corwin triggers it. There is no possible explanation that I can think of. Even though we arent setting the teamcolor uniforms correctly, but that is beyond the issue here.

UnitShape breaks all map rendering (with corwin!)

Important: sometimes, after a while, I cant reproduce the bug. /luaui reset always brings it back :D

[Bluestone]

Kloot already knew the answer - ​https://springrts.com/mantis/view.php?id=5184

Also, it appears to have been my fault...

[Bluestone]

In [5300], I think you should instead check if the shader is nil and delete if not (I guess [5300] will have broken smth minor with luaui reload). After that, should be able to close this?

[beherith]

Shader variable was not even localized. If I localize shader, and do a nil check before deletion, the bug returns. The shader is recreated anyway for luaui reload, it should be fine.

[Bluestone]

n2s, might still be an issue with option changes, which also calls UpdateEverything()